Merge pull request #627 from evo-lua/static-analysis-env

Create a new .env file to use pinned versions in the linter workflow
evo-lua · Jan 7, 2025 · a11a65d · a11a65d
2 parents 7cd49e8 + f940ea6
commit a11a65d
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 16 deletions.
diff --git a/.github/static-analysis.env b/.github/static-analysis.env
@@ -0,0 +1,4 @@
+EVO_CPPCHECK_VERSION=2.16.0
+EVO_SELENE_VERSION=0.27.1
+EVO_LUAROCKS_VERSION=3.11.1
+EVO_LUACHECK_VERSION=1.2.0-1
diff --git a/.github/workflows/static-analysis.yml b/.github/workflows/static-analysis.yml
@@ -19,39 +19,48 @@ jobs:
   luacheck:
     name: Lint codebase
     runs-on: ubuntu-24.04
-    env:
-        CPPCHECK_VERSION: 2.16.0
     steps:
 
+      - name: Check out Git repository
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 1
+          submodules: false
+
+      - name: Set up environment
+        run: |
+          set -a
+          source .github/static-analysis.env
+          cat .github/static-analysis.env >> $GITHUB_ENV
+          echo $(pwd) >> $GITHUB_PATH
+
       # LuaRocks needs the 5.1 headers to compile LuaCheck later, so we download them, too
       - name: Install LuaJIT
         run: sudo apt-get install luajit libluajit-5.1-dev
 
       - name: Download LuaRocks
-        run: wget https://luarocks.org/releases/luarocks-3.9.1.tar.gz
+        run: wget https://luarocks.org/releases/luarocks-$EVO_LUAROCKS_VERSION.tar.gz
 
       - name: Unpack LuaRocks release
-        run: tar zxpf luarocks-3.9.1.tar.gz
+        run: tar zxpf luarocks-$EVO_LUAROCKS_VERSION.tar.gz
 
       - name: Install LuaRocks
-        run: cd luarocks-3.9.1 && ./configure && make && sudo make install
+        run: |
+            cd luarocks-$EVO_LUAROCKS_VERSION
+            ./configure
+            make
+            sudo make install
+            cd -
+            rm -rfv luarocks-$EVO_LUAROCKS_VERSION
 
       - name: Install LuaCheck
-        run: sudo luarocks install luacheck
-
-      # We don't want LuaCheck to analyze LuaRocks itself
-      # Ironically, it fails when doing that, but that's not useful here
-      - name: Change to temporary directory
-        run: mkdir temp && cd temp
-
-      - name: Check out Git repository
-        uses: actions/checkout@v4
+        run: sudo luarocks install luacheck $EVO_LUACHECK_VERSION
 
       - name: Run luacheck
         run: luacheck .
 
       - name: Install selene
-        run: cargo install selene
+        run: cargo install selene@$EVO_SELENE_VERSION
 
       - name: Run selene
         run: selene .
@@ -62,7 +71,7 @@ jobs:
           git clone --depth 1 https://github.com/danmar/cppcheck.git
           cd cppcheck
           git fetch --tags
-          git checkout $CPPCHECK_VERSION
+          git checkout $EVO_CPPCHECK_VERSION
           mkdir build
           cd build
           cmake ..