fix: check --cmd-binary only if cmd plugin is used

evilsocket · Dec 20, 2023 · e25d6e9 · e25d6e9
1 parent 50f2854
commit e25d6e9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/plugins/cmd/mod.rs b/src/plugins/cmd/mod.rs
@@ -64,7 +64,11 @@ impl Plugin for Command {
 
     fn setup(&mut self, opts: &Options) -> Result<(), Error> {
         self.opts = opts.cmd.clone();
-        Ok(())
+        if self.opts.cmd_binary.is_empty() {
+            Err("please provide --cmd-binary and optionally --cmd-args".to_owned())
+        } else {
+            Ok(())
+        }
     }
 
     async fn attempt(&self, creds: &Credentials, timeout: Duration) -> Result<Option<Loot>, Error> {

diff --git a/src/plugins/cmd/options.rs b/src/plugins/cmd/options.rs
@@ -4,7 +4,7 @@ use serde::{Deserialize, Serialize};
 #[derive(Parser, Debug, Serialize, Deserialize, Clone, Default)]
 #[group(skip)]
 pub(crate) struct Options {
-    #[clap(long)]
+    #[clap(long, default_value = "")]
     /// Command binary path.
     pub cmd_binary: String,