Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsonschema): add $schema property #942

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mst-mkt
Copy link

@mst-mkt mst-mkt commented Jan 30, 2025

⚡ Summary

In the current jsonschema, specifying $schema results in a warning as shown in the following image.

This is because "additionalProperties": false and there is no $schema in properties.

image

To resolve this, the $schema property was added.
This approach has been observed in other projects as well, such as @biomejs/biome.

    "properties": {
+     "$schema": {
+       "type": "string"
+     },
    },

I am not very familiar with Go, so I would appreciate any corrections or suggestions.

☑️ Checklist

  • Check locally
  • Add tests
  • Add documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant