Add dual UI system #1045
Add dual UI system #1045
Conversation
roihershberg
commented
May 14, 2022
•
roihershberg
commented
- Duplicate MainActivity, settings fragment and realted files.
- Add a setting to toggle between UIs and an activity launcher that launches the corresponding activity.
- Resolve DI and ToxService's notification intent
- Change the new theme to be based on material design.
|
I don't think we should preemptively duplicate the majority of the codebase. Why is it needed? |
|
It is for the freedom of changing everything that is related to UI. We need another MainActivity so we can change the nav host however we like as well as all the fragments. Edit: Maybe we can indeed just duplicate things one by one when it is needed. |
roihershberg
force-pushed
the
add_dual_ui
branch
from
bcba10d to
7ec4515
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.
roihershberg
force-pushed
the
add_dual_ui
branch
from
7ec4515 to
c214d3e
Compare
There was a problem hiding this comment.
Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.
roihershberg
force-pushed
the
add_dual_ui
branch
from
c214d3e to
0fab261
Compare
There was a problem hiding this comment.
Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.
|
You can use the "Compare with" functionality in Android Studio to see what changes have been made after I have duplicated a file. For example, you can select in the project tree both SettingsFragment.kt via the Ctrl key and then click Ctrl+D and you will see what I have changed. |
* Duplicate MainActivity, settings fragment and realted files. * Add a setting to toggle between UIs and an activity launcher that launches the corresponding activity. * Resolve DI and ToxService's notification intent * Change the new theme to be based on material design.
roihershberg
force-pushed
the
add_dual_ui
branch
from
0fab261 to
61e2e47
Compare
There was a problem hiding this comment.
Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.
