Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove package files left after revert commit #1112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

carlosallexandre
Copy link
Contributor

Rever commit 7559d42

Motivation

This PR remove package files left after revert commit 7559d42.
The package file was introduced with PR #987.

This package is causing confusion when updating dependencies. Actually, EC is using only the root package.json.

Copy link

changeset-bot bot commented Jan 24, 2025

⚠️ No Changeset found

Latest commit: b5acb0b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@boyney123
Copy link
Collaborator

Just catching up, so are we removing package.json file from the eventcatalog folder now? If I understand correctly?

@carlosallexandre
Copy link
Contributor Author

Just catching up, so are we removing package.json file from the eventcatalog folder now? If I understand correctly?

That's right 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants