Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): use gray-matter to stringify dependencies frontmatter #1083

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

craig0990
Copy link
Contributor

@craig0990 craig0990 commented Jan 10, 2025

Motivation

Use gray-matter to generate dependencies frontmatter, as per discussion in #1081

Fixes #1081

  • Not sure how you feel about the [].join() for the markdown 🥲 (Never know how to format multi-lines where indentation affects output)
  • Not sure how you feel about the changeset wording

@craig0990 craig0990 requested a review from boyney123 as a code owner January 10, 2025 11:56
Copy link

changeset-bot bot commented Jan 10, 2025

🦋 Changeset detected

Latest commit: 23d2ebf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eventcatalog/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@craig0990 craig0990 force-pushed the main branch 2 times, most recently from 6ce9623 to 806f8e1 Compare January 10, 2025 13:04
@craig0990
Copy link
Contributor Author

Well that's embarassing. Updated to:

  • Rebase for pnpm
  • Import commonjs style instead of named imports
  • Format with prettier
  • Run pnpm run verify-build:catalog locally to check ✅
  • Seems the docker test has changed?

@boyney123
Copy link
Collaborator

Thank you @craig0990 , this looks good to me, sorry it's taken awhile to review, I have been head down on presentation stuff for a couple of weeks. Let's get this in!

@boyney123 boyney123 merged commit c8f86b7 into event-catalog:main Jan 23, 2025
4 checks passed
@boyney123
Copy link
Collaborator

@all-contributors add @craig0990 for code

Copy link
Contributor

@boyney123

I've put up a pull request to add @craig0990! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent YAML front-matter escape between dependencies vs. Event Catalog SDK
2 participants