Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small performance increase. #16

Merged
merged 1 commit into from
May 15, 2020
Merged

Small performance increase. #16

merged 1 commit into from
May 15, 2020

Conversation

ytrezq
Copy link
Contributor

@ytrezq ytrezq commented May 7, 2020

Test the most used instructions first and the less likely scenarios least. And if an opcode is having a specific value, it also means it can’t have other values at the same time.

The reason behind this is the way CPython compares Object values take times (poor timings).

Will win a little less than 2 minutes over a 30 minutes run if the timeout limit along node count is raised accordingly.

Test the most used instructions first and the less likely scenarios least. And if an opcode is having a specific value, it also means it can’t have other values at the same time.
Will win a little less than 2 minutes if the timeout limit along node count is raised accordingly.
palkeo pushed a commit to palkeo/panoramix that referenced this pull request May 8, 2020
@kolinko kolinko merged commit 0e52ba4 into eveem-org:master May 15, 2020
@kolinko
Copy link
Contributor

kolinko commented May 15, 2020

Awesome, thanks, @ytrezq ! <3

Copy link

@Nixdu0815 Nixdu0815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np ;)

@Tinye420 Tinye420 mentioned this pull request Oct 21, 2021
@onemliii onemliii linked an issue Feb 27, 2023 that may be closed by this pull request
@Iransovran Iransovran linked an issue Apr 6, 2023 that may be closed by this pull request
Copy link

@jonesk7734 jonesk7734 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@cum8197
Copy link

cum8197 commented Jun 11, 2024

0e52ba4

@cum8197
Copy link

cum8197 commented Jun 11, 2024

6c5ac01

7 similar comments
@cum8197
Copy link

cum8197 commented Jun 11, 2024

6c5ac01

@cum8197
Copy link

cum8197 commented Jun 11, 2024

6c5ac01

@cum8197
Copy link

cum8197 commented Jun 11, 2024

6c5ac01

@cum8197
Copy link

cum8197 commented Jun 11, 2024

6c5ac01

@cum8197
Copy link

cum8197 commented Jun 11, 2024

6c5ac01

@cum8197
Copy link

cum8197 commented Jun 11, 2024

6c5ac01

@cum8197
Copy link

cum8197 commented Jun 11, 2024

6c5ac01

@100manbul
Copy link

/**
*Submitted for verification at Etherscan.io on 2019-04-20
*/

pragma solidity 0.5.2;

// File: openzeppelin-solidity/contracts/token/ERC20/IERC20.sol

/**

  • @title ERC20 interface

  • @dev see ERC: Token standard ethereum/EIPs#20
    */
    interface IERC20 {
    function transfer(address to, uint256 value) external returns (bool);

    function approve(address spender, uint256 value) external returns (bool);

    function transferFrom(address from, address to, uint256 value) external returns (bool);

    function totalSupply() external view returns (uint256);

    function balanceOf(address who) external view returns (uint256);

    function allowance(address owner, address spender) external view returns (uint256);

    event Transfer(address indexed from, address indexed to, uint256 value);

    event Approval(address indexed owner, address indexed spender, uint256 value);
    }

// File: openzeppelin-solidity/contracts/math/SafeMath.sol

/**

  • @title SafeMath

  • @dev Unsigned math operations with safety checks that revert on error
    /
    library SafeMath {
    /
    *

    /**

    • @dev Integer division of two unsigned integers truncating the quotient, reverts on division by zero.
      */
      function div(uint256 a, uint256 b) internal pure returns (uint256) {
      // Solidity only automatically asserts when dividing by 0
      require(b > 0);
      uint256 c = a / b;
      // assert(a == b * c + a % b); // There is no case in which this doesn't hold

      return c;
      }

    /**

    • @dev Subtracts two unsigned integers, reverts on overflow (i.e. if subtrahend is greater than minuend).
      */
      function sub(uint256 a, uint256 b) internal pure returns (uint256) {
      require(b <= a);
      uint256 c = a - b;

      return c;
      }

    /**

    • @dev Adds two unsigned integers, reverts on overflow.
      */
      function add(uint256 a, uint256 b) internal pure returns (uint256) {
      uint256 c = a + b;
      require(c >= a);

      return c;
      }

    /**

    • @dev Divides two unsigned integers and returns the remainder (unsigned integer modulo),
    • reverts when dividing by zero.
      */
      function mod(uint256 a, uint256 b) internal pure returns (uint256) {
      require(b != 0);
      return a % b;
      }
      }

// File: openzeppelin-solidity/contracts/token/ERC20/ERC20.sol

/**

  • @title Standard ERC20 token

  • @dev Implementation of the basic standard token.

  • https://github.com/ethereum/EIPs/blob/master/EIPS/eip-20.md

  • Originally based on code by FirstBlood:

  • https://github.com/Firstbloodio/token/blob/master/smart_contract/FirstBloodToken.sol

  • This implementation emits additional Approval events, allowing applications to reconstruct the allowance status for

  • all accounts just by listening to said events. Note that this isn't required by the specification, and other

  • compliant implementations may not do it.
    */
    contract ERC20 is IERC20 {
    using SafeMath for uint256;

    mapping (address => uint256) private _balances;

    mapping (address => mapping (address => uint256)) private _allowed;

    uint256 private _totalSupply;

    /**

    • @dev Total number of tokens in existence
      */
      function totalSupply() public view returns (uint256) {
      return _totalSupply;
      }

    /**

    • @dev Gets the balance of the specified address.
    • @param owner The address to query the balance of.
    • @return An uint256 representing the amount owned by the passed address.
      */
      function balanceOf(address owner) public view returns (uint256) {
      return _balances[owner];
      }

    /**

    • @dev Function to check the amount of tokens that an owner allowed to a spender.
    • @param owner address The address which owns the funds.
    • @param spender address The address which will spend the funds.
    • @return A uint256 specifying the amount of tokens still available for the spender.
      */
      function allowance(address owner, address spender) public view returns (uint256) {
      return _allowed[owner][spender];
      }

    /**

    • @dev Transfer token for a specified address
    • @param to The address to transfer to.
    • @param value The amount to be transferred.
      */
      function transfer(address to, uint256 value) public returns (bool) {
      _transfer(msg.sender, to, value);
      return true;
      }

    /**

    • @dev Approve the passed address to spend the specified amount of tokens on behalf of msg.sender.

    • Beware that changing an allowance with this method brings the risk that someone may use both the old

    • and the new allowance by unfortunate transaction ordering. One possible solution to mitigate this

    • race condition is to first reduce the spender's allowance to 0 and set the desired value afterwards:

    • ERC: Token standard ethereum/EIPs#20 (comment)

    • @param spender The address which will spend the funds.

    • @param value The amount of tokens to be spent.
      */
      function approve(address spender, uint256 value) public returns (bool) {
      require(spender != address(0));

      _allowed[msg.sender][spender] = value;
      emit Approval(msg.sender, spender, value);
      return true;
      }

    /**

    • @dev Transfer tokens from one address to another.
    • Note that while this function emits an Approval event, this is not required as per the specification,
    • and other compliant implementations may not emit the event.
    • @param from address The address which you want to send tokens from
    • @param to address The address which you want to transfer to
    • @param value uint256 the amount of tokens to be transferred
      */
      function transferFrom(address from, address to, uint256 value) public returns (bool) {
      _allowed[from][msg.sender] = _allowed[from][msg.sender].sub(value);
      _transfer(from, to, value);
      emit Approval(from, msg.sender, _allowed[from][msg.sender]);
      return true;
      }

    /**

    • @dev Increase the amount of tokens that an owner allowed to a spender.

    • approve should be called when allowed_[_spender] == 0. To increment

    • allowed value is better to use this function to avoid 2 calls (and wait until

    • the first transaction is mined)

    • From MonolithDAO Token.sol

    • Emits an Approval event.

    • @param spender The address which will spend the funds.

    • @param addedValue The amount of tokens to increase the allowance by.
      */
      function increaseAllowance(address spender, uint256 addedValue) public returns (bool) {
      require(spender != address(0));

      _allowed[msg.sender][spender] = _allowed[msg.sender][spender].add(addedValue);
      emit Approval(msg.sender, spender, _allowed[msg.sender][spender]);
      return true;
      }

    /**

    • @dev Decrease the amount of tokens that an owner allowed to a spender.

    • approve should be called when allowed_[_spender] == 0. To decrement

    • allowed value is better to use this function to avoid 2 calls (and wait until

    • the first transaction is mined)

    • From MonolithDAO Token.sol

    • Emits an Approval event.

    • @param spender The address which will spend the funds.

    • @param subtractedValue The amount of tokens to decrease the allowance by.
      */
      function decreaseAllowance(address spender, uint256 subtractedValue) public returns (bool) {
      require(spender != address(0));

      _allowed[msg.sender][spender] = _allowed[msg.sender][spender].sub(subtractedValue);
      emit Approval(msg.sender, spender, _allowed[msg.sender][spender]);
      return true;
      }

    /**

    • @dev Transfer token for a specified addresses

    • @param from The address to transfer from.

    • @param to The address to transfer to.

    • @param value The amount to be transferred.
      */
      function _transfer(address from, address to, uint256 value) internal {
      require(to != address(0));

      _balances[from] = _balances[from].sub(value);
      _balances[to] = _balances[to].add(value);
      emit Transfer(from, to, value);
      }

    /**

    • @dev Internal function that mints an amount of the token and assigns it to

    • an account. This encapsulates the modification of balances such that the

    • proper events are emitted.

    • @param account The account that will receive the created tokens.

    • @param value The amount that will be created.
      */
      function _mint(address account, uint256 value) internal {
      require(account != address(0));

      _totalSupply = _totalSupply.add(value);
      _balances[account] = _balances[account].add(value);
      emit Transfer(address(0), account, value);
      }

    /**

    • @dev Internal function that burns an amount of the token of a given

    • account.

    • @param account The account whose tokens will be burnt.

    • @param value The amount that will be burnt.
      */
      function _burn(address account, uint256 value) internal {
      require(account != address(0));

      _totalSupply = _totalSupply.sub(value);
      _balances[account] = _balances[account].sub(value);
      emit Transfer(account, address(0), value);
      }

    /**

    • @dev Internal function that burns an amount of the token of a given
    • account, deducting from the sender's allowance for said account. Uses the
    • internal burn function.
    • Emits an Approval event (reflecting the reduced allowance).
    • @param account The account whose tokens will be burnt.
    • @param value The amount that will be burnt.
      */
      function _burnFrom(address account, uint256 value) internal {
      _allowed[account][msg.sender] = _allowed[account][msg.sender].sub(value);
      _burn(account, value);
      emit Approval(account, msg.sender, _allowed[account][msg.sender]);
      }
      }

// File: openzeppelin-solidity/contracts/access/Roles.sol

/**

  • @title Roles

  • @dev Library for managing addresses assigned to a Role.
    */
    library Roles {
    struct Role {
    mapping (address => bool) bearer;
    }

    /**

    • @dev give an account access to this role
      */
      function add(Role storage role, address account) internal {
      require(account != address(0));
      require(!has(role, account));

      role.bearer[account] = true;
      }

    /**

    • @dev remove an account's access to this role
      */
      function remove(Role storage role, address account) internal {
      require(account != address(0));
      require(has(role, account));

      role.bearer[account] = false;
      }

    /**

    • @dev check if an account has this role
    • @return bool
      */
      function has(Role storage role, address account) internal view returns (bool) {
      require(account != address(0));
      return role.bearer[account];
      }
      }

// File: openzeppelin-solidity/contracts/access/roles/PauserRole.sol

contract PauserRole {
using Roles for Roles.Role;

event PauserAdded(address indexed account);
event PauserRemoved(address indexed account);

Roles.Role private _pausers;

constructor () internal {
    _addPauser(msg.sender);
}

modifier onlyPauser() {
    require(isPauser(msg.sender));
    _;
}

function isPauser(address account) public view returns (bool) {
    return _pausers.has(account);
}

function addPauser(address account) public onlyPauser {
    _addPauser(account);
}

function renouncePauser() public {
    _removePauser(msg.sender);
}

function _addPauser(address account) internal {
    _pausers.add(account);
    emit PauserAdded(account);
}

function _removePauser(address account) internal {
    _pausers.remove(account);
    emit PauserRemoved(account);
}

}

// File: openzeppelin-solidity/contracts/lifecycle/Pausable.sol

/**

  • @title Pausable

  • @dev Base contract which allows children to implement an emergency stop mechanism.
    */
    contract Pausable is PauserRole {
    event Paused(address account);
    event Unpaused(address account);

    bool private _paused;

    constructor () internal {
    _paused = false;
    }

    /**

    • @return true if the contract is paused, false otherwise.
      */
      function paused() public view returns (bool) {
      return _paused;
      }

    /**

    • @dev Modifier to make a function callable only when the contract is not paused.
      */
      modifier whenNotPaused() {
      require(!_paused);
      _;
      }

    /**

    • @dev Modifier to make a function callable only when the contract is paused.
      */
      modifier whenPaused() {
      require(_paused);
      _;
      }

    /**

    • @dev called by the owner to pause, triggers stopped state
      */
      function pause() public onlyPauser whenNotPaused {
      _paused = true;
      emit Paused(msg.sender);
      }

    /**

    • @dev called by the owner to unpause, returns to normal state
      */
      function unpause() public onlyPauser whenPaused {
      _paused = false;
      emit Unpaused(msg.sender);
      }
      }

// File: openzeppelin-solidity/contracts/token/ERC20/ERC20Pausable.sol

/**

  • @title Pausable token

  • @dev ERC20 modified with pausable transfers.
    **/
    contract ERC20Pausable is ERC20, Pausable {
    function transfer(address to, uint256 value) public whenNotPaused returns (bool) {
    return super.transfer(to, value);
    }

    function transferFrom(address from, address to, uint256 value) public whenNotPaused returns (bool) {
    return super.transferFrom(from, to, value);
    }

    function approve(address spender, uint256 value) public whenNotPaused returns (bool) {
    return super.approve(spender, value);
    }

    function increaseAllowance(address spender, uint addedValue) public whenNotPaused returns (bool success) {
    return super.increaseAllowance(spender, addedValue);
    }

    function decreaseAllowance(address spender, uint subtractedValue) public whenNotPaused returns (bool success) {
    return super.decreaseAllowance(spender, subtractedValue);
    }
    }

// File: openzeppelin-solidity/contracts/token/ERC20/ERC20Detailed.sol

/**

  • @title ERC20Detailed token

  • @dev The decimals are only for visualization purposes.

  • All the operations are done using the smallest and indivisible token unit,

  • just as on Ethereum all the operations are done in wei.
    */
    contract ERC20Detailed is IERC20 {
    string private _name;
    string private _symbol;
    uint8 private _decimals;

    constructor (string memory name, string memory symbol, uint8 decimals) public {
    _name = name;
    _symbol = symbol;
    _decimals = decimals;
    }

    /**

    • @return the name of the token.
      */
      function
      }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AIT Önemli