-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small performance increase. #16
Conversation
Test the most used instructions first and the less likely scenarios least. And if an opcode is having a specific value, it also means it can’t have other values at the same time. Will win a little less than 2 minutes if the timeout limit along node count is raised accordingly.
Awesome, thanks, @ytrezq ! <3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed
7 similar comments
/** pragma solidity 0.5.2; // File: openzeppelin-solidity/contracts/token/ERC20/IERC20.sol /**
// File: openzeppelin-solidity/contracts/math/SafeMath.sol /**
// File: openzeppelin-solidity/contracts/token/ERC20/ERC20.sol /**
// File: openzeppelin-solidity/contracts/access/Roles.sol /**
// File: openzeppelin-solidity/contracts/access/roles/PauserRole.sol contract PauserRole {
} // File: openzeppelin-solidity/contracts/lifecycle/Pausable.sol /**
// File: openzeppelin-solidity/contracts/token/ERC20/ERC20Pausable.sol /**
// File: openzeppelin-solidity/contracts/token/ERC20/ERC20Detailed.sol /**
|
Test the most used instructions first and the less likely scenarios least. And if an opcode is having a specific value, it also means it can’t have other values at the same time.
The reason behind this is the way CPython compares Object values take times (poor timings).
Will win a little less than 2 minutes over a 30 minutes run if the timeout limit along node count is raised accordingly.