Various small fixes #50
Conversation
Fix compilation warnings.
(to reproduce, compile QEMU with gcc 13 using --cc).
tcg/tcg-op-vec.c
Outdated
| op->args[4] = d; | ||
| op->args[5] = e; | ||
| } | ||
| // static void vec_gen_6(TCGOpcode opc, TCGType type, unsigned vece, TCGArg r, |
There was a problem hiding this comment.
Can you use C comments like elsewhere ? And add a note on why this is commented out vs removed (I imagine this is unused now but may be useful later ?)
There was a problem hiding this comment.
It's an effect of -werror, unused symbols will make the compilation fail (it was treated as warning before).
I'll adapt the comment style and add a comment.
It's better to keep it commented imho for future merges with QEMU, maybe this will become used elsewhere one day.
tcg/tcg-op-vec.c
Outdated
| } | ||
| return true; | ||
| } | ||
| // static bool do_op2(unsigned vece, TCGv_vec r, TCGv_vec a, TCGOpcode opc) |
tcg/tcg-op-vec.c
Outdated
| TCGArg bi = temp_arg(bt); | ||
| TCGArg ci = temp_arg(ct); | ||
| TCGArg di = temp_arg(dt); | ||
| // TCGArg ri = temp_arg(rt); |
tcg/tcg-op-vec.c
Outdated
| @@ -1083,7 +1083,7 @@ void tcg_gen_cmpsel_vec(TCGCond cond, unsigned vece, TCGv_vec r, | |||
|
|
|||
| tcg_assert_listed_vecop(INDEX_op_cmpsel_vec); | |||
| hold_list = tcg_swap_vecop_list(NULL); | |||
| can = tcg_can_emit_vec_op(INDEX_op_cmpsel_vec, type, vece); | |||
| // can = tcg_can_emit_vec_op(INDEX_op_cmpsel_vec, type, vece); | |||
Dockerfile
Outdated
|
|
||
| RUN add-apt-repository ppa:ubuntu-toolchain-r/test -y | ||
|
|
||
| RUN apt update && apt install -y \ |
There was a problem hiding this comment.
Actually sync and install on the same line is a good idea no ? e.g.:
https://stackoverflow.com/a/61439544
Keep it on the same line ?
There was a problem hiding this comment.
Yep. I always group apt udpate and apt install in docker files to avoid the problem mentionned in the link you sent.
The thing you saw in the dockerfile that I reverted was to install the latest version of gcc and llvm for testing. Maybe this is something we may reuse in the future (like for testing with different versions of llvm)?
|
Ah didn't know about this. |
Make example more simple. Commented out unused QEMU code.
|
merged with #51. |
Fixes for some compilation problems I've met.
Also, now docker building is more strict and compiles with TCG debug asserts and werror.