[BUG] Method TSDataset.tsdataset_idx_slice loses hierarchical structure
#618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-618--etna-docs.netlify.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #618 +/- ##
==========================================
+ Coverage 90.47% 90.49% +0.02%
==========================================
Files 259 259
Lines 18041 18038 -3
==========================================
+ Hits 16323 16324 +1
+ Misses 1718 1714 -4 ☔ View full report in Codecov by Sentry. |
d-a-bunin
reviewed
Feb 24, 2025
d-a-bunin
reviewed
Feb 24, 2025
etna/datasets/tsdataset.py
Outdated
| tsdataset_slice._target_components_names = deepcopy(self._target_components_names) | ||
| tsdataset_slice._prediction_intervals_names = deepcopy(self._prediction_intervals_names) | ||
| return tsdataset_slice | ||
| ts_slice = deepcopy(self) |
There was a problem hiding this comment.
Don't we want to make it in a more optimized way like in train_test_split?
d-a-bunin
reviewed
Feb 24, 2025
d-a-bunin
reviewed
Feb 24, 2025
d-a-bunin
reviewed
Feb 25, 2025
d-a-bunin
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Closing issues
closes #439