Update MAPE, SMAPE to handle missing values #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-524--etna-docs.netlify.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #524 +/- ##
=======================================
Coverage 90.32% 90.32%
=======================================
Files 256 256
Lines 17221 17227 +6
=======================================
+ Hits 15555 15561 +6
Misses 1666 1666 ☔ View full report in Codecov by Sentry. |
d-a-bunin
reviewed
Dec 13, 2024
added 2 commits
December 13, 2024 13:52
# Conflicts: # tests/test_metrics/test_metrics.py
d-a-bunin
reviewed
Dec 13, 2024
CHANGELOG.md
Outdated
| @@ -31,7 +31,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - Add docstring warning about handling non-regressors (including target) to children of `WindowStatisticsTransform` ([#474](https://github.com/etna-team/etna/pull/474)) | |||
| - Add parameter `missing_mode` into `MSE` metric ([#515](https://github.com/etna-team/etna/pull/515)) | |||
| - Add parameter `missing_mode` into `MAE` metric ([#523](https://github.com/etna-team/etna/pull/523)) | |||
| - | |||
| - Add parameter `missing_mode` into `MAPE` and `SMAPE` metrics ([#524](https://github.com/etna-team/etna/issues/521)) | |||
There was a problem hiding this comment.
Link here should be ([#524](https://github.com/etna-team/etna/pull/524))
d-a-bunin
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
See #521
Closing issues
See #521