Feat/persistent service client refactor #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 19, 2024 23:28
…os_queues and updated building documentation
- Added the ${ros_boosted_utilities_INCLUDE_DIRS} in the include of the catkin_package of the ros_queue since the persistent service class is a template and the ros_queue libraries doesn't build anything (since they are mainly templates). Thus, the package that depends on ros_queue will now also include the header files to build the persistent client template.
…ervice client The QueueController already implemented a kind of persistent service through a persistent connection check function called before calling the service. To have a more uniform code, this check has been replaced by changing the ros::ServiceClient by PersistentServiceClient classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added persistent service clients to the queue server and changed the persistent mechanism of the queue controller for the new PersistentServoceClient.
Udpated the READMEs.