Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pro 1846 factory contract support #66

Merged
merged 8 commits into from
Oct 25, 2023

Conversation

poocart
Copy link
Contributor

@poocart poocart commented Oct 25, 2023

Added Changes

  • Added accountTemplate to <EtherspotTransactionKit /> component that allows passing custom factoryWallet supported by Prime SDK

@linear
Copy link

linear bot commented Oct 25, 2023

PRO-1846 TransactionKit: Factory Contract support

Description:

Currently we need to add support to allow a user to add their own Factory Contract to be used instead of the one that the Etherspot Prime service will use by detault.

A developer will be able to pass a string that should be mapped to an available ENUM that is referenced in the Etherspot Prime SDK. This is then passed on to the Etherspot Prime SDK.

Pre-requisites:

  • Prime SDK support for custom factory contracts

Requirements:

  • Modify TransactionKit so that:
    • A new property, factoryContract is added to the <EtherspotBatches> tag which:
      • Accepts a camel case string such as zeroDev which is automatically converted to a ENUM style capitalised snake case value which is then attempted to be mapped to an existing ENUM
        • If the ENUM does not exist or was not found, defaults to "etherspot"
      • passes this on to the SDK
    • Code must be:
      • Documentated within the code via doc blocks
      • Tests must be written

Resources:

User stories:

  • Success stories
    • As a developer, i should be able to use a different factory contract if i so choose

Specific Acceptance Criteria:

  • As per the user stories above.

@poocart poocart requested a review from IAmKio October 25, 2023 11:27
@poocart poocart merged commit 60e5676 into master Oct 25, 2023
2 checks passed
@poocart poocart deleted the feature/PRO-1846-factory-contract-support branch October 25, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants