Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/PRO-2576/update-new-wallet-factory #159

Merged
merged 7 commits into from
Aug 9, 2024
Merged

fix/PRO-2576/update-new-wallet-factory #159

merged 7 commits into from
Aug 9, 2024

Conversation

RanaBug
Copy link
Contributor

@RanaBug RanaBug commented Aug 8, 2024 •
edited
Loading

Description

  • Update of the Modular SDK version, which changes the wallet factory address

How Has This Been Tested?

  • Existing unit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@RanaBug RanaBug requested review from IAmKio and vignesha22 August 8, 2024 13:12
@RanaBug RanaBug self-assigned this Aug 8, 2024
@linear Linear
Copy link

linear bot commented Aug 8, 2024

PRO-2576 Update TransactionKit + PillarX with new Wallet Factory for Modular

vignesha22
vignesha22 previously approved these changes Aug 8, 2024
View reviewed changes
Copy link

@vignesha22 vignesha22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RanaBug RanaBug merged commit 985fd00 into master Aug 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vignesha22 vignesha22 vignesha22 approved these changes

@IAmKio IAmKio Awaiting requested review from IAmKio

Assignees

@RanaBug RanaBug

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RanaBug @vignesha22