-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/PRO-2416/upgrade-prime-modular-accounts #155
Conversation
Yooo! You forgot to bump the version in package.json! |
Yooo! You forgot to bump the version in package.json! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on what has been a troublesome proceed! Just a few things mentioned yesterday and to help the developer experience 🚀 but overall, great work!
…ld be used, updated tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small thing and what we talked about over Slack but we're nearly there!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So close!
CHANGELOG.md
Outdated
- Added `isModular` to context `EtherspotContextProvider` | ||
|
||
### Breaking Changes | ||
- Etherspot Modular SDK implemented to Transaction Kit as the default `accountTemplate` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Etherspot Modular SDK implemented to Transaction Kit as the default `accountTemplate` | |
- Etherspot Modular SDK implemented to TransactionKit as the default `accountTemplate` |
CHANGELOG.md
Outdated
|
||
### Breaking Changes | ||
- Etherspot Modular SDK implemented to Transaction Kit as the default `accountTemplate` | ||
- The account template in the `EtherspotTransactionKit` component, can only be 'etherspot' if `moddular` is true. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The account template in the `EtherspotTransactionKit` component, can only be 'etherspot' if `moddular` is true. |
CHANGELOG.md
Outdated
### Breaking Changes | ||
- Etherspot Modular SDK implemented to Transaction Kit as the default `accountTemplate` | ||
- The account template in the `EtherspotTransactionKit` component, can only be 'etherspot' if `moddular` is true. | ||
- Changed the `etherspot-prime` wallet type to `etherpot` wallet type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Changed the `etherspot-prime` wallet type to `etherpot` wallet type | |
- Changed the `etherspot-prime` wallet type to `etherspot` wallet type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFGGGG 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀
Description
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes