Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/PRO-2416/upgrade-prime-modular-accounts #155

Merged
merged 6 commits into from
Jun 18, 2024

Conversation

RanaBug
Copy link
Contributor

@RanaBug RanaBug commented Jun 17, 2024

Description

  • Implementation of the Modular SDK to install and uninstall modules
  • Can install and uninstall only one module per wallet, until next update
  • Modular SDK is now the default SDK
  • Updated tests

How Has This Been Tested?

  • Updated existing tests and added a new test file for install and uninstall modules
  • Tested on the example App

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ X ] New feature (non-breaking change which adds functionality)
  • [ X ] Breaking change (fix or feature that would cause existing functionality to change)

@RanaBug RanaBug requested a review from IAmKio June 17, 2024 16:26
@RanaBug RanaBug self-assigned this Jun 17, 2024
Copy link

linear bot commented Jun 17, 2024

Copy link

Yooo! You forgot to bump the version in package.json!

Copy link

Yooo! You forgot to bump the version in package.json!

Copy link
Contributor

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on what has been a troublesome proceed! Just a few things mentioned yesterday and to help the developer experience 🚀 but overall, great work!

__mocks__/@etherspot/modular-sdk.js Outdated Show resolved Hide resolved
__tests__/hooks/useEtherspotModules.test.js Outdated Show resolved Hide resolved
__tests__/hooks/useWalletAddress.test.js Outdated Show resolved Hide resolved
example/src/App.tsx Outdated Show resolved Hide resolved
src/components/EtherspotTransactionKit.tsx Outdated Show resolved Hide resolved
src/components/EtherspotTransactionKit.tsx Show resolved Hide resolved
src/hooks/useEtherspotModules.ts Outdated Show resolved Hide resolved
src/hooks/useEtherspotModules.ts Outdated Show resolved Hide resolved
src/hooks/useEtherspotModules.ts Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing and what we talked about over Slack but we're nearly there!

src/providers/EtherspotContextProvider.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close!

CHANGELOG.md Outdated
- Added `isModular` to context `EtherspotContextProvider`

### Breaking Changes
- Etherspot Modular SDK implemented to Transaction Kit as the default `accountTemplate`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Etherspot Modular SDK implemented to Transaction Kit as the default `accountTemplate`
- Etherspot Modular SDK implemented to TransactionKit as the default `accountTemplate`

CHANGELOG.md Outdated

### Breaking Changes
- Etherspot Modular SDK implemented to Transaction Kit as the default `accountTemplate`
- The account template in the `EtherspotTransactionKit` component, can only be 'etherspot' if `moddular` is true.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The account template in the `EtherspotTransactionKit` component, can only be 'etherspot' if `moddular` is true.

CHANGELOG.md Outdated
### Breaking Changes
- Etherspot Modular SDK implemented to Transaction Kit as the default `accountTemplate`
- The account template in the `EtherspotTransactionKit` component, can only be 'etherspot' if `moddular` is true.
- Changed the `etherspot-prime` wallet type to `etherpot` wallet type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Changed the `etherspot-prime` wallet type to `etherpot` wallet type
- Changed the `etherspot-prime` wallet type to `etherspot` wallet type

Copy link
Contributor

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFGGGG 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀

@RanaBug RanaBug merged commit fdcb718 into master Jun 18, 2024
5 checks passed
@IAmKio IAmKio deleted the feat/PRO-2416/upgrade-prime-modular-accounts branch June 18, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants