Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate bundler and data services api keys #127

Merged
merged 1 commit into from
Mar 20, 2024
Merged

separate bundler and data services api keys #127

merged 1 commit into from
Mar 20, 2024

Conversation

poocart
Copy link
Contributor

@poocart poocart commented Mar 20, 2024 •
edited
Loading

Description

  • Etherspot project keys are now split as dataApiKey and bundlerApiKey to support separation of bundler and data services, however TransactionKit still carries embedded keys with low frequency usage API calls support

How Has This Been Tested?

  • Local tests and example dapp.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

kaushalrajbacancy
kaushalrajbacancy approved these changes Mar 20, 2024
View reviewed changes
Copy link

@kaushalrajbacancy kaushalrajbacancy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poocart poocart merged commit d8e5cb9 into master Mar 20, 2024
4 of 5 checks passed
@poocart poocart deleted the fix/api-keys-fix branch March 20, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAmKio IAmKio IAmKio approved these changes

@arddluma arddluma arddluma approved these changes

@kaushalrajbacancy kaushalrajbacancy kaushalrajbacancy approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@poocart @IAmKio @arddluma @kaushalrajbacancy