Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/local instance cached address #103

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Feature/local instance cached address #103

merged 2 commits into from
Feb 22, 2024

Conversation

poocart
Copy link
Contributor

@poocart poocart commented Feb 21, 2024

Description

  • Added Etherspot Prime SDK computed account pull from SDK instance state

How Has This Been Tested?

  • Local dapp.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@poocart poocart changed the base branch from master to feature/token-decimals-on-token-components February 21, 2024 21:24
@poocart poocart changed the title Feature/local instabce cached address Feature/local instance cached address Feb 21, 2024
@poocart poocart requested a review from IAmKio February 21, 2024 21:32
IAmKio
IAmKio requested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change but other than that looks great!

src/hooks/useWalletAddress.ts Outdated Show resolved Hide resolved
IAmKio
IAmKio previously approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@poocart poocart changed the base branch from feature/token-decimals-on-token-components to master February 22, 2024 10:21
@poocart poocart dismissed IAmKio’s stale review February 22, 2024 10:21

The base branch was changed.

@poocart poocart merged commit 1c6756e into master Feb 22, 2024
4 checks passed
@poocart poocart deleted the feature/local-instabce-cached-address branch February 22, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAmKio IAmKio IAmKio left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poocart @IAmKio