Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRO - 1967 - GitHub issues #68

Merged
merged 8 commits into from
Nov 13, 2023
Merged

PRO - 1967 - GitHub issues #68

merged 8 commits into from
Nov 13, 2023

Conversation

vignesha22
Copy link
Contributor

@vignesha22 vignesha22 commented Nov 7, 2023

Description

  • Updated paymaster url to accept arka api_key and chainId as queryString
  • Added optional parameters such as entryPointAddress and Factory walletAddress for custom chain interaction
  • Bug fixes for handling errors on connecting with custom chain interaction

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

Copy link

github-actions bot commented Nov 7, 2023

Yooo! You forgot to bump the version in package.json!

Copy link

github-actions bot commented Nov 7, 2023

Yooo! You forgot to bump the version in package.json!

@0xSulpiride
Copy link
Member

#64 addressed in the commit above

Copy link
Member

@0xSulpiride 0xSulpiride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Can we also add scripts in package.json for the examples 16 and 19?

Copy link
Contributor

@kaushalrajbacancy kaushalrajbacancy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ch4r10t33r ch4r10t33r linked an issue Nov 9, 2023 that may be closed by this pull request
@ch4r10t33r
Copy link
Member

@vignesha22 Pls merge this ticket.

@vignesha22 vignesha22 merged commit 61db48b into master Nov 13, 2023
2 checks passed
@vignesha22 vignesha22 deleted the PRO-1967-Github_Issues branch November 13, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants