Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arka_Paymaster_Fix #137

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Arka_Paymaster_Fix #137

merged 2 commits into from
Dec 13, 2024

Conversation

vignesha22
Copy link
Contributor

Description

  • Added 0x before sending userOp to paymaster since DUMMY_PAYMASTER_DATA has an invalid address on the first 20 bytes

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

ch4r10t33r
ch4r10t33r approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vignesha22 vignesha22 merged commit 7fbedb6 into master Dec 13, 2024
6 checks passed
@vignesha22 vignesha22 deleted the Arka_Paymaster_Fix branch December 13, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilkumar1612 nikhilkumar1612 nikhilkumar1612 approved these changes

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@cryptonoyaiba cryptonoyaiba Awaiting requested review from cryptonoyaiba

@0xSulpiride 0xSulpiride Awaiting requested review from 0xSulpiride

@kanthgithub kanthgithub Awaiting requested review from kanthgithub

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vignesha22 @ch4r10t33r @nikhilkumar1612