Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: module-install check to be done only for existing modular-wallet #43

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

kanthgithub
Copy link
Contributor

@kanthgithub kanthgithub commented Oct 14, 2024

Description

module-install check to be done only for existing modular-wallets and skip the check for to be initialised modular-wallets

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)

…s and skip the check for to be initialised modular-wallets
@kanthgithub kanthgithub self-assigned this Oct 14, 2024
Copy link

Yooo! You forgot to bump the version in package.json!

CHANGELOG.md Outdated
@@ -1,4 +1,10 @@
# Changelog

## [2.0.6] - 2024-10-14
### Breaking Changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a breaking change. As the user wouldn't need to change anything at their end. However we will recommend everyone to upgrade their version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to bugfix

Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

@kanthgithub kanthgithub merged commit 6b89431 into master Oct 14, 2024
4 checks passed
@kanthgithub kanthgithub deleted the bugfix/get-nonce-validation-check branch October 14, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants