Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: PRO-2373 migrate ethers to viem #24

Closed
wants to merge 20 commits into from

Conversation

kanthgithub
Copy link
Contributor

@kanthgithub kanthgithub commented Jul 22, 2024

Migrate etherspot-modular-sdk from ethers to viem

Description

  • viem dependency added to package.json
  • ModularSDK, EtherSpotWalletAPI and dependant typescript classes are refactored to
    • use viem account, PublicClient, WalletClient
    • remove references and injection of privateKey to SDK initialisation
    • create custom types for BigNumber, UserOpsStructs
    • remove typechain references of the etherspot-module-contracts
    • add ABI constants for all functions of modular-contracts being used in SDK

Manual Testing

Test Strategy:
Key functions of the Modular Smartcontracts:

  1. getCounterFactualAddress
  2. install module
  3. list modules
  4. uninstall modules
  5. native and erc20 transfer via UserOps to a recipient
  6. Smart Wallet creation for a new EOA account

Example scripts in the directory: are used to test above set of scenarios
The SDK function path will cove most of the migrated set of functions while testing above list of scenarios

Test Networks

Scenarios are tested on Sepolia and Amoy

Test Proofs

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring
  • Build related changes

Copy link

linear bot commented Jul 22, 2024

@kanthgithub kanthgithub self-assigned this Jul 22, 2024
@kanthgithub kanthgithub mentioned this pull request Jul 22, 2024
8 tasks
@kanthgithub kanthgithub changed the title Feature/pro 2373 migrate ethers to viem Feature: PRO-2373 migrate ethers to viem Jul 22, 2024
@kanthgithub kanthgithub force-pushed the feature/PRO-2373-Migrate-Ethers-To-Viem branch from 4eeb6da to 17eb2ff Compare July 31, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant