Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRO-2267 - Etherscan API #80

Merged
merged 2 commits into from
Apr 1, 2024
Merged

PRO-2267 - Etherscan API #80

merged 2 commits into from
Apr 1, 2024

Conversation

vignesha22
Copy link
Contributor

Description

  • Added fetching of gas price from etherscan
  • Added a new ENV var ETHERSCAN_GAS_ORACLES to input the urls of all chains that we want to fetch as optional if there is no url found, it will switch to taking gas price from provider directly

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@linear Linear
Copy link

linear bot commented Mar 25, 2024

PRO-2267 Arka: Use Etherscan API as gas oracle

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Mar 25, 2024 •
edited
Loading

Deploying arka with  Cloudflare Pages  Cloudflare Pages

Latest commit: b14df6c
Status: ✅  Deploy successful!
Preview URL: https://4b76eb05.arka-3qg.pages.dev
Branch Preview URL: https://pro-2267-etherscanapi.arka-3qg.pages.dev

View logs

ch4r10t33r
ch4r10t33r requested changes Mar 25, 2024
View reviewed changes
backend/src/paymaster/index.ts Show resolved Hide resolved
backend/src/paymaster/index.ts Show resolved Hide resolved
backend/src/paymaster/index.ts Show resolved Hide resolved
backend/src/paymaster/index.ts Show resolved Hide resolved
@vignesha22 vignesha22 merged commit c42caae into master Apr 1, 2024
4 checks passed
@vignesha22 vignesha22 deleted the PRO-2267-EtherscanApi branch April 1, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@0xSulpiride 0xSulpiride Awaiting requested review from 0xSulpiride

@cryptonoyaiba cryptonoyaiba Awaiting requested review from cryptonoyaiba

@kaushalrajbacancy kaushalrajbacancy Awaiting requested review from kaushalrajbacancy

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vignesha22 @ch4r10t33r