Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRO-2723 - Standardisation #162

Merged
merged 4 commits into from
Jan 27, 2025
Merged

PRO-2723 - Standardisation #162

merged 4 commits into from
Jan 27, 2025

Conversation

vignesha22
Copy link
Contributor

Description

  • changed pimlicoAddress endpoint name to tokenPaymasterAddress the functionality remains the same
  • Changed the following endpoint names to be camelCases:-
    • /policy/wallet-address/:walletAddress to /policy/walletAddress/:walletAddress
    • /policy/wallet-address/:walletAddress/ep-version/:epVersion to /policy/walletAddress/:walletAddress/epVersion/:epVersion
    • /policy/wallet-address/:walletAddress/ep-version/:epVersion/chain-id/:chainId to /policy/walletAddress/:walletAddress/epVersion/:epVersion/chainId/:chainId
    • /policy/wallet-address/:walletAddress/latest to /policy/walletAddress/:walletAddress/latest
    • /policy/wallet-address/:walletAddress/chain-id/:chainId/latest to /policy/walletAddress/:walletAddress/chainId/:chainId/latest
    • /policy/wallet-address/:walletAddress/ep-version/:epVersion/latest to /policy/walletAddress/:walletAddress/epVersion/:epVersion/latest
    • /policy/wallet-address/:walletAddress/ep-version/:epVersion/chainId/:chain-id/latest to /policy/walletAddress/:walletAddress/epVersion/:epVersion/chainId/:chainId/latest
    • /add-policy to /addPolicy
    • /delete-policy/:id to /deletePolicy/:id
    • /update-policy to /updatePolicy
    • /enable-policy/:id to /enablePolicy/:id
    • /disable-policy/:id to /disablePolicy/:id

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

Copy link

linear bot commented Jan 9, 2025

Copy link

cloudflare-workers-and-pages bot commented Jan 22, 2025

Deploying arka with  Cloudflare Pages  Cloudflare Pages

Latest commit: b25b286
Status: ✅  Deploy successful!
Preview URL: https://07cf10ed.arka-3qg.pages.dev
Branch Preview URL: https://pro-2723-standardisation.arka-3qg.pages.dev

View logs

Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls change version number of 3.0.0 and then merge. Looks good.

@vignesha22 vignesha22 changed the base branch from master to develop January 23, 2025 09:51
Base automatically changed from develop to master January 27, 2025 14:18
@vignesha22 vignesha22 changed the base branch from master to develop January 27, 2025 14:23
@vignesha22 vignesha22 merged commit fa21e02 into develop Jan 27, 2025
3 checks passed
@vignesha22 vignesha22 deleted the PRO-2723-Standardisation branch January 27, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants