-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post capella block verification #710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with minimal feedback. Some comments in the code explaining what is happening would be helpful.
packages/era/src/helpers.ts
Outdated
@@ -55,6 +56,26 @@ export const deserializeE2Store = (bytes: Uint8Array): e2StoreEntry[] => { | |||
return entries | |||
} | |||
|
|||
|
|||
function littleEndianToBigInt(bytes: Uint8Array) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the ethjs bytesToBigInt
function not work here? It has a littleEndian: boolean = false
parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I switch to bytesToBigInt
, my tests start failing so something's awry. Will research a bit more.
60fbbef
to
e65ce17
Compare
era
files and better error handlingHistoricalSummaries
HistoricalSummaries
presentHistoryNetwork.validateHeader