Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state: Simplify code modification indicator in StateDiff #1117

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

chfast
Copy link
Member

@chfast chfast commented Jan 27, 2025

Use std::optional to indicate that an account's code has changed in the state diff.

@chfast chfast requested a review from gumb0 January 27, 2025 14:19
@chfast
Copy link
Member Author

chfast commented Jan 27, 2025

For testing, I will rebase #961 on top of this.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.29%. Comparing base (f9f328b) to head (3e16ad7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1117   +/-   ##
=======================================
  Coverage   94.29%   94.29%           
=======================================
  Files         159      159           
  Lines       17323    17325    +2     
=======================================
+ Hits        16335    16337    +2     
  Misses        988      988           
Flag Coverage Δ
eof_execution_spec_tests 15.91% <92.30%> (+<0.01%) ⬆️
ethereum_tests 26.89% <76.92%> (+<0.01%) ⬆️
ethereum_tests_silkpre 18.98% <83.33%> (+0.01%) ⬆️
execution_spec_tests 21.10% <61.53%> (+<0.01%) ⬆️
unittests 89.03% <92.30%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/state/account.hpp 100.00% <ø> (ø)
test/state/host.cpp 100.00% <100.00%> (ø)
test/state/state.cpp 98.44% <100.00%> (ø)
test/state/state_diff.hpp 100.00% <ø> (ø)
test/state/test_state.cpp 100.00% <100.00%> (ø)

@chfast
Copy link
Member Author

chfast commented Jan 28, 2025

I test-rebased eip-7702 on top of this and it looks smooth and all tests passed.

@chfast chfast merged commit 9d28979 into master Jan 28, 2025
25 checks passed
@chfast chfast deleted the state/diff_code_update branch January 28, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants