Add Stenix chain with chain id 425 #5951
Conversation
|
You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review. |
|
Do I need make changes or just confirm the changes?
пн, 7 жовт. 2024, 18:34 користувач ligi ***@***.***> пише:
… ***@***.**** requested changes on this pull request.
------------------------------
In _data/chains/eip155-425.json
<#5951 (comment)>
:
> + "nativeCurrency": {
+ "name": "Stenix",
+ "symbol": "STEN",
+ "decimals": 18
+ },
+ "features": [{ "name": "EIP155" }, { "name": "EIP1559" }],
+ "infoURL": "https://stenix.org",
+ "shortName": "sten",
+ "chainId": 425,
+ "networkId": 425,
+ "icon": "stenix",
+ "explorers": [{
+ "name": "stenscan",
+ "url": "https://stenscan.com",
+ "icon": "stenscan",
+ "standard": "EIP3091"
explorer does not seem to conform to EIP3091
⬇️ Suggested change
- "standard": "EIP3091"
+ "standard": "none"
------------------------------
In _data/icons/stenix.json
<#5951 (comment)>
:
> @@ -0,0 +1,9 @@
+
⬇️ Suggested change
-
------------------------------
In _data/icons/stenscan.json
<#5951 (comment)>
:
> @@ -0,0 +1,9 @@
+
⬇️ Suggested change
-
—
Reply to this email directly, view it on GitHub
<#5951 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVA7JNT2463IHADPGZAAJ4LZ2KSZXAVCNFSM6AAAAABPPZXBF2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNJSGMYDSMBRGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
you can just apply the changes |
|
Ok, thank you , I will
вт, 8 жовт. 2024, 19:57 користувач ligi ***@***.***> пише:
… you can just apply the changes
—
Reply to this email directly, view it on GitHub
<#5951 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVA7JNSZAZD36H5KHO72JHDZ2QFJPAVCNFSM6AAAAABPPZXBF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBQGM4DGNBYHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Co-authored-by: ligi <[email protected]>
Co-authored-by: ligi <[email protected]>
Co-authored-by: ligi <[email protected]>
|
I apply the changes, but don't understand what's wrong now? |
There was a problem hiding this comment.
Please run the prettier to format your json according to the style defined here
e.g. run npx prettier --write _data/*/*.json
|
done |
|
please check again, thank you. ipfs icon is online now |
|
PR merged - please consider contributing some funds to lists.eth |
added new chain called Stenix with chain id 425