Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cronos zkEVM Testnet Chain-ID #5937

Closed
wants to merge 5 commits into from

Conversation

aw126
Copy link
Contributor

@aw126 aw126 commented Oct 4, 2024

Hello @ligi, as official chain-id for Cronos zkEVM Testnet has changed from 282 to 240, this PR is to make this update on Chainlist.

Hello @ligi, as official chain-id for Cronos zkEVM Testnet has changed from `282` to `240`, this PR is reflect this update on Chainlist.
Copy link

github-actions bot commented Oct 4, 2024

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

Copy link

@Eikyarkway Eikyarkway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you cannot remove chains - only mark them deprecated

@aw126
Copy link
Contributor Author

aw126 commented Oct 7, 2024

you cannot remove chains - only mark them deprecated

Thanks for the reply @ligi. ReadMe mentions adding a status field to deprecate a chain, but it’s unclear where exactly to add it. Could you clarify where exactly the status field should go and how to properly deprecate a chain with an outdated chain ID? After that, we will re-add the chain details with the new chain-id.

@ElvisKrop
Copy link
Contributor

Hey @aw126 👋
Here is an example of chain deprecation pr: #5485

@aw126
Copy link
Contributor Author

aw126 commented Oct 23, 2024

Hey @aw126 👋 Here is an example of chain deprecation pr: #5485

Hey @ElvisKrop, thanks for sharing it 👍

@aw126 aw126 closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants