Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve schema for environments.yaml #80

Merged
merged 6 commits into from
Apr 5, 2023
Merged

Improve schema for environments.yaml #80

merged 6 commits into from
Apr 5, 2023

Conversation

bcumming
Copy link
Member

@bcumming bcumming commented Mar 23, 2023 •
edited
Loading

  • Disallow additional properties in environments
  • Improve schema formatting

@bcumming bcumming added the bug Something isn't working label Mar 23, 2023
@bcumming bcumming added this to the v2 milestone Apr 5, 2023
RMeli
RMeli reviewed Apr 5, 2023
View reviewed changes
unittests/test_schema.py Outdated Show resolved Hide resolved
@bcumming bcumming merged commit c02a269 into master Apr 5, 2023
RMeli
RMeli approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your linter workaround ;) Probably we should increase the number of characters per line.

@bcumming bcumming deleted the fix/schema branch April 18, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMeli RMeli RMeli approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.
2 participants
@bcumming @RMeli