Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run chmod -R a+rX $(STORE) before creating sqfs #206

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

simonpintarelli
Copy link
Member

Should we run chmod -R a+rX $(STORE) before creating the squashfs file?

Currently chmod needs to be run manually in post-install. User wouldn't need to think about this when writing post-install hooks.

Ping @lukasgd.

@bcumming
Copy link
Member

Naive question: what is the reason for this?

@simonpintarelli
Copy link
Member Author

For example when manually installing packages in post-install, it is likely one needs to add chmod, since the files are owned by root and not world-readable:
https://github.com/biddisco/alps-spack-stacks/blob/paraview/recipes/paraview/5.13.2/gh200/post-install#L208

Having everything in $(STORE) world-readable seems a sane default. Although currently it is mostly redundant, since we take care of permissions for the bulk of the files in other places.

@bcumming bcumming merged commit 701ccf8 into master Jan 16, 2025
13 checks passed
@simonpintarelli simonpintarelli deleted the chmodarX branch January 16, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants