Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a couple of missing spack --color=never #184

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

albestro
Copy link
Contributor

After spack/spack#42334 stackinator started raising some errors due to colorised output.

Just for reference, the error look like this

env: ‘\033[1m/user-environment/linux-sles15-zen/gcc-7.5.0/squashfs-4.6.1-pl5475bjii2xaf3cafaflr2yidf5754h\033[0m/bin/mksquashfs’: No such file or directory

In other places spack --color=never is already used, so I just applied the same solution also in the other parts that were triggering the error.

This applies for sure to develop branch, but in principle it should not harm in general.

Actually, I think it might be a good idea to have a different $(SPACK) variable that already embeds the --color=never, so it can be safely used where we use spack not as build tool but as helper to retrieve information (e.g. get install prefix).

@bcumming
Copy link
Member

Thanks @albestro.

I agree about replacing SPACK with SPACK_HELPER.

@albestro albestro force-pushed the alby/fix-colorised-output branch from a7708b8 to 3b43aab Compare April 23, 2024 07:12
@albestro
Copy link
Contributor Author

@bcumming is it the way you were thinking about it?

@bcumming bcumming merged commit 54b7b1d into eth-cscs:master Apr 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants