Add a couple of missing spack --color=never #184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After spack/spack#42334 stackinator started raising some errors due to colorised output.
Just for reference, the error look like this
In other places
spack --color=never
is already used, so I just applied the same solution also in the other parts that were triggering the error.This applies for sure to
develop
branch, but in principle it should not harm in general.Actually, I think it might be a good idea to have a different
$(SPACK)
variable that already embeds the--color=never
, so it can be safely used where we use spack not as build tool but as helper to retrieve information (e.g. get install prefix).