Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable use-any rule from revive #19120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Jan 1, 2025

Description

enable use-any rule from revive

Also sort revive rules alphabetically

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorel-35
Once this PR has been reviewed and has the lgtm label, please assign wenjiaswe for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.81%. Comparing base (f307354) to head (ae6749c).

Additional details and impacted files
Files with missing lines Coverage Δ
server/embed/config.go 79.43% <100.00%> (ø)

... and 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19120      +/-   ##
==========================================
+ Coverage   68.79%   68.81%   +0.01%     
==========================================
  Files         420      420              
  Lines       35640    35640              
==========================================
+ Hits        24520    24526       +6     
+ Misses       9696     9689       -7     
- Partials     1424     1425       +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f307354...ae6749c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants