-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Member tests in parallel #19035
base: main
Are you sure you want to change the base?
Run Member tests in parallel #19035
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AwesomePatrol The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @AwesomePatrol. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 21 files with indirect coverage changes @@ Coverage Diff @@
## main #19035 +/- ##
==========================================
+ Coverage 68.79% 68.88% +0.09%
==========================================
Files 420 420
Lines 35640 35642 +2
==========================================
+ Hits 24518 24552 +34
+ Misses 9697 9664 -33
- Partials 1425 1426 +1 Continue to review full report in Codecov by Sentry.
|
ee67c51
to
bda32aa
Compare
This comment was marked as outdated.
This comment was marked as outdated.
bda32aa
to
cbeb76e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
879c0f0
to
2febbd8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
In addition to this, have you considered using paralleltest ? |
c1f333a
to
3085967
Compare
Thanks for your suggestion. Running tests in parallel requires more changes than just adding |
This comment was marked as outdated.
This comment was marked as outdated.
Introduce port allocator and remove unused MemberNumber. Add UniquePortAlloc config field so that default behavior will stay unchanged. On my local machine it brings down execution time from 5m to 32s. Signed-off-by: Aleksander Mistewicz <[email protected]>
Signed-off-by: Aleksander Mistewicz <[email protected]>
Otherwise `go test` would execute GOMAXPROCS parallel tests running `--cpu` number of processes (1,2,4) which could starve cpu in some cases. Signed-off-by: Aleksander Mistewicz <[email protected]>
3085967
to
cfc4e15
Compare
/retest |
@AwesomePatrol: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
On my local machine it brings down execution time from 5 minutes to 32s.
I added a port allocator which allocates ports in 11000-19000 range.
Issue: #18983