feat(es_extended/client/modules/action): add TrackJumping on SlowLoop… #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(es_extended/client/modules/death): fix death thread on first spawn
1.12.4 Hotfix
|
I think this is quite necessary |
|
This would need to run every frame to be reliable. In addition to that, it is too specific for a framework-wide cache for my liking. There's maybe a handful of resources where I could imagine someone would need this, which in turn doesn't justify caching this every frame. Though I appreciate the effort you put into your contribution, I don't think this has a place in the framework.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addition of a jumping system in slowloop to make things easier when needed, such as event jumping in the previous version