Improved AddSharedAccount function #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added parameter checks. Database insert checks. Returns boolean and error message if needed.
removed exports from fxmanifest and added inside server/main.lua
Instead of returning "success" it now returns the account on success
Kenshiin13
reviewed
Feb 18, 2025
- Changed return value from `true/false` to return the account table on success and `nil` on failure. - Error if parameters or DB insertion are not success. - Removed redundant checks
|
Corrected |
Kenshiin13
requested changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the AddSharedAccount() function. Now returns boolean with message. Added checks to validate parsed parameters. Also check for database insertion.
Removed exports from fxmanifest (as suggested earlier) and added directly inside server/main.lua