Hiding messaging when external payments are provided #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a blank message in case we want to put something there Updating store names to match what they're doing now
2 tasks
Fetching the info from the initial loading of tenant data
kiahna-tucker
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Is there a reason why this component shouldn't return null when an external payment method is detected? The argument I would make against returning null in this scenario is to more easily accommodate external payment method messaging in the future.
The only minor oddity with the current approach is that the loading state will still be displayed when externalPaymentMethod is true despite the message not having any content.
Comment on lines
+73
to
+80
| return !tenantBillingDetails | ||
| ? false | ||
| : tenantBillingDetails.some((tenantBillingDetail) => { | ||
| return ( | ||
| tenantBillingDetail.tenant === selectedTenant && | ||
| tenantBillingDetail.payment_provider === 'external' | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Is there a benefit to using a ternary as opposed to the nullish coalescing operator?
travjenkins
deleted the
travjenkins/bug/fix-billing-content-for-external-payments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
contributes to #1419
Changes
1419
externalpayment providerTests
Manually tested
stripeandexternalpayment tenantsAutomated tests
Playwright tests ran locally
Screenshots
stripepayment for tenantexternalpayment for tenant