Do not require tenant creation for SSO users #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
their admin user for next steps. Adding ability to show an alert in onboarding
travjenkins
commented
Jan 3, 2025
Comment on lines
+30
to
+32
| if (usedSSO && !showBeta) { | ||
| return <SsoUserMessage />; | ||
| } |
There was a problem hiding this comment.
Allowing folks to still force show the sign up flow.
travjenkins
changed the title
Providing a clickable URL
kiahna-tucker
approved these changes
Jan 6, 2025
renaming file sharing variables
…so-for-tenant' into travjenkins/feature/do-not-ask-sso-for-tenant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#1391
Changes
1391
Tests
Manually tested
Automated tests
Playwright tests ran locally
Screenshots
Show alert and hide tenant creation form when using SSO
Users can still access the tenant creation using URL params
OAuth users are not impacted