Phil/ts codegen fix #1855
Merged
Phil/ts codegen fix #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We saw a derivation that failed validation because the generated Typescript code was syntactically invalid. This was caused by the inferred `Shape` having an empty set of enum variants (`enum_: Some([])`). The empty enum variants cause the generated code to omit any sort of type, which causes Deno to fail to parse it. I'm not completely certain whether the fault is with the Typescript code generation or the Shape inferrence, but it's pretty easy to filter out empty enums in the code generation, which results in generated code correctly having the `never` type. I also added a debug log of the generated types file, so that this type of thing is easier to debug in the future.
jshearer
approved these changes
Jan 7, 2025
psFried
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a bug in Typescript code generation when the intersection of two schemas results in an enum property that is not allowed to exist.
This change is