Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prefix for deploying in subpath #178

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

redzioch
Copy link

Purpose

When go-httpbin is served using subpath (eg. https://server.url/subpath) you need to provide PREFIX environmental variable. Without it, links on main page won't be working properly. According to go-httpbin docs:

PREFIX Prefix of path to listen on (must start with slash and does not end with slash)

With prefix you need to update probes accordingly.

Changes

  • added appConfig.prefix value
  • passed it as $ENV.PREFIX to container
  • updated probes paths

Testing

Deployed and tested on my dev environment

Code Author Checklist

  • Bump the chart version (Chart.yaml -> version)
  • JSON Schema updated (values.schema.json)
  • Update README.md via helm-docs (or make prep)
  • Run pre-commit run --all-files via pre-commit (or make prep)
  • Update Artifacthub annotation (Chart.yaml -> artifacthub.io/changes, artifacthub.io/images)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant