Update pre-commit config to run formatting check on all files (IEC-268) #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
tomassebestik
requested review from
tore-espressif and
peter-marcisovsky
and removed request for
tore-espressif
espressif-bot
added
Status: Selected for Development
peter-marcisovsky
approved these changes
Feb 19, 2025
Update .pre-commit-config.yaml so that formatting checks (e.g., trailing whitespaces and line endings) run on all files, instead of only C/C++ files.
Fixes formatting issues (e.g., trailing whitespaces, line endings) caught by pre-commit when running "pre-commit run --all-files".
Dazza0
force-pushed
the
feat/pre_commit_format_checks_all_files
branch
from
b7a41eb to
214b815
Compare
|
@tore-espressif @peter-marcisovsky Thanks for the quick review. Have added |
roma-jam
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
.pre-commit-config.yamlformatting checks (e.g., trailing whitespace and line endings) will only run on C/C++ source files. This has caused some formatting issues to slip through in other files types (e.g.,.mdand.txt).This PR updates
.pre-commit-config.yamlso that formatting checks are run on all file types, and also fixes formatting issues caught bypre-commit run --all-files.Related
Testing
Checklist
Before submitting a Pull Request, please ensure the following: