Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(host/uvc): Fixed negotiation for some non-conforming UVC devices #129

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

tore-espressif
Copy link
Collaborator

Some UVC devices require to set alternate setting to 0 before the negotiation starts.

Closes espressif/esp-idf#9868

@tore-espressif
Copy link
Collaborator Author

cc @lijunru-hub

@tore-espressif tore-espressif requested a review from igi540 February 4, 2025 13:40
@roma-jam
Copy link
Collaborator

roma-jam commented Feb 4, 2025

Still have the same problem as I described here: #84 (comment)
This is the diff I made to run the example/basic_uvc_stream:
image

This is the log:
image

UPD: I have added the Alt Settings, because this is the only one obvious difference in the beagle trace: #84 (comment)

What may be related or can give you some ideas (but I need to change it every time): on my board the ESP PSRAM uses Octal Mode.

Copy link
Collaborator

@roma-jam roma-jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one note, mentioned above.
Otherwise, LGTM.

Copy link
Collaborator

@peter-marcisovsky peter-marcisovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one note. Tired on my Logitech camera, works fine.

Some UVC devices require to set alternate setting to 0 before the negotiation starts.

Closes espressif/esp-idf#9868
@tore-espressif tore-espressif merged commit 9c4d6a2 into master Feb 4, 2025
36 checks passed
@tore-espressif tore-espressif deleted the fix/uvc_set_interface branch February 4, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration descriptor larger than control transfer max length (IDFGH-8401)
3 participants