fix(modem): Added test injecting unexpected replies #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
euripedesrocha
approved these changes
Dec 6, 2023
This test exhibits an issue of getting unexpected data just after completing a command. The DTE rewrites the state to TIMEOUT, but the signal has been already triggered, thus results in an unexpected state. Related to Closes espressif#426
david-cermak
force-pushed
the
fix/modem_command_state_consistent_test
branch
from
bb416f9 to
b220d1e
Compare
|
Thanks for the review @euripedesrocha The test (previously failing on https://github.com/espressif/esp-protocols/actions/runs/7058401985/job/19213908309) now passed after including bf99f28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test exhibits an issue of getting unexpected data just after completing a command. The DTE rewrites the state to TIMEOUT, but the signal has been already triggered, thus results in an unexpected state.
Related to Closes #426