Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added component: Console for runtime network interface configuration #332

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Added component: Console for runtime network interface configuration #332

merged 2 commits into from
Nov 30, 2023

Conversation

espressif-abhikroy
Copy link
Collaborator

Console for runtime network interface configuration and monitoring.

@CLAassistant
Copy link

CLAassistant commented Jul 28, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@espressif-abhikroy espressif-abhikroy force-pushed the components/console_cmd_ifconfig branch 3 times, most recently from ede360d to d5fec78 Compare July 28, 2023 14:40
@espressif-abhikroy espressif-abhikroy force-pushed the components/console_cmd_ifconfig branch 6 times, most recently from 516174f to 967f6ad Compare August 21, 2023 10:00
@espressif-abhikroy espressif-abhikroy marked this pull request as ready for review August 21, 2023 13:42
@espressif-abhikroy espressif-abhikroy force-pushed the components/console_cmd_ifconfig branch 5 times, most recently from 4d96574 to 212d296 Compare September 12, 2023 10:56
@espressif-abhikroy espressif-abhikroy force-pushed the components/console_cmd_ifconfig branch 2 times, most recently from 3784a43 to e71b04f Compare September 19, 2023 10:06
@espressif-abhikroy espressif-abhikroy force-pushed the components/console_cmd_ifconfig branch 5 times, most recently from a6ccc13 to 63f668d Compare October 17, 2023 10:16
david-cermak
david-cermak requested changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left few minor comments

components/console_cmd_ifconfig/console_ifconfig.c Outdated Show resolved Hide resolved
components/console_cmd_ifconfig/console_ifconfig.c Outdated Show resolved Hide resolved
components/console_cmd_ifconfig/console_ifconfig.c Outdated Show resolved Hide resolved
components/console_cmd_ifconfig/console_ifconfig.c Outdated Show resolved Hide resolved
components/console_cmd_ifconfig/console_ifconfig.c Outdated Show resolved Hide resolved
components/console_cmd_ifconfig/console_ifconfig.c Outdated Show resolved Hide resolved
components/console_cmd_ifconfig/console_ifconfig.c Outdated Show resolved Hide resolved
components/console_cmd_ifconfig/console_ifconfig.c Outdated Show resolved Hide resolved
components/console_cmd_ifconfig/examples/ifconfig-basic/main/idf_component.yml Outdated Show resolved Hide resolved
@espressif-abhikroy espressif-abhikroy force-pushed the components/console_cmd_ifconfig branch 2 times, most recently from 6ee4739 to 851a0e6 Compare October 18, 2023 08:27
@espressif-abhikroy espressif-abhikroy force-pushed the components/console_cmd_ifconfig branch 7 times, most recently from 43413f3 to 8c8d627 Compare October 25, 2023 10:06
@espressif-abhikroy espressif-abhikroy marked this pull request as draft October 26, 2023 07:33
@espressif-abhikroy espressif-abhikroy force-pushed the components/console_cmd_ifconfig branch 2 times, most recently from cb00fd9 to 57b522f Compare October 26, 2023 10:02
@espressif-abhikroy espressif-abhikroy force-pushed the components/console_cmd_ifconfig branch from 57b522f to 0c9266f Compare November 16, 2023 09:05
@espressif-abhikroy espressif-abhikroy marked this pull request as ready for review November 16, 2023 09:06
@espressif-abhikroy espressif-abhikroy force-pushed the components/console_cmd_ifconfig branch from 0c9266f to 7ad35b5 Compare November 23, 2023 09:10
@espressif-abhikroy espressif-abhikroy force-pushed the components/console_cmd_ifconfig branch from 7ad35b5 to 8bab142 Compare November 24, 2023 09:07
@espressif-abhikroy
bump(console): First version [1.0.0]
76a4a9f 
1.0.0
Features
- Console for runtime network interface configuration and monitoring (8bab142)
@david-cermak david-cermak merged commit 1bf6843 into espressif:master Nov 30, 2023
23 checks passed
@espressif-abhikroy espressif-abhikroy deleted the components/console_cmd_ifconfig branch December 1, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@euripedesrocha euripedesrocha euripedesrocha left review comments

@igrr igrr igrr left review comments

@kostaond kostaond kostaond left review comments

@david-cermak david-cermak david-cermak approved these changes

@gabsuren gabsuren Awaiting requested review from gabsuren

Assignees

@espressif-abhikroy espressif-abhikroy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@espressif-abhikroy @CLAassistant @euripedesrocha @igrr @david-cermak @kostaond