Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transport_ws): remove unnecessary noise from error message (IDFGH-14538) #15300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erkia
Copy link

@erkia erkia commented Jan 29, 2025

A message reporting an error about esp_transport_read() prints contents of the buffer that was passed to this function. The contents of this buffer are irrelevant in the context of this message.

  1. it can contain random, not NUL-terminated data from possibly partial read
  2. it can contain data from previous esp_transport_write() call that is using the same buffer.

In either case this is just a noise:

Screenshot_20250129_151900

@CLAassistant
Copy link

CLAassistant commented Jan 29, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Jan 29, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello erkia, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against b1c3b69

@espressif-bot espressif-bot added the Status: Opened Issue is new label Jan 29, 2025
@github-actions github-actions bot changed the title fix(transport_ws): remove unnecessary noise from error message fix(transport_ws): remove unnecessary noise from error message (IDFGH-14538) Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Opened Issue is new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants