-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(storage/fatfs): Compiler unused warnings (IDFGH-14289) #15081
base: master
Are you sure you want to change the base?
Conversation
👋 Hello safocl, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Hi, thank you for the contribution! Left a small note regarding the code. Could you please also clean-up the commit history to only have the one commit with changes. |
what's the best way to do that? |
63d7790
to
0b8d98d
Compare
f559b7c
to
d69d767
Compare
Again, thank you for the contribution! Just a note, it might take a few days to get through our internal process and propagate back to github. |
I think this is definitely needed -- any changes should be tested as thoroughly as possible (everyone can make mistakes) |
Hi, sorry, but one more change is needed. Could you please modify the commit message fit the required format
Something along the lines of Thank you. |
esp-idf/components/fatfs/diskio/diskio_rawflash.c warning: unused variable 'part' [-Wunused-variable] XX | const esp_partition_t* part = s_ff_raw_handles[pdrv]; | ^~~~ esp-idf/components/fatfs/vfs/vfs_fat_sdmmc.c warning: unused variable 'found' [-Wunused-variable] XXX | bool found = s_get_context_id_by_card(card, &id); | ^~~~~
Description
Some variables inserted to asserts, but it produce the warning reports with CONFIG_COMPILER_ASSERT_NDEBUG_EVALUATE=n :
This PR fix it (remove temporary unused variables).
Checklist
Before submitting a Pull Request, please ensure the following:
Upd:
6326508 fix