fix(esp_common): fix C++ variant of ESP_RETURN_VOID_ON_FALSE (IDFGH-14125)

[chschu]

Description

This PR fixes the ESP_RETURN_VOID_ON_FALSE macro used for recent versions of C++.

The macro parameter err_code is removed from the macro's parameter list. Other variants of the macro do not have that parameter, and it isn't used in the macro definition.

Checklist

Before submitting a Pull Request, please ensure the following:

• 🚨 This PR does not introduce breaking changes.
  • I'm not sure about that. It could be considered a breaking change, because existing C++ code might use the macro with the extra parameter.
• All CI checks (GH Actions) pass.
• Documentation is updated as needed.
• Tests are updated or added as necessary.
• Code is well-commented, especially in complex areas.
• Git history is clean — commits are squashed to the minimum necessary.

[CLAassistant]

All committers have signed the CLA.

[github-actions]

	Messages
📖	🎉 Good Job! All checks are passing!

👋 Hello chschu, we appreciate your contribution to this project!

---

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

---

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

---

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against f948622

[safocl]

Can't https://github.com/espressif/esp-idf-cxx/blob/7532e372082dce481c1435bb82e880aca96b08c7/include/esp_exception.hpp#L49 be used for this?

[chschu]

Even though CHECK_THROW and ESP_RETURN_VOID_ON_FALSE both interrupt control flow, they are fundamentally different. In particular, ESP_RETURN_VOID_ON_FALSE can be used with exceptions disabled.

The PR is not about using a different macro. It simply aligns the signatures of the three different definitions of ESP_RETURN_VOID_ON_FALSE.

[ESP-Marius]

@chschu sorry, this one seems to have slipped through the cracks.

Changes seems reasonable to me!

[ESP-Marius]

sha=f94862243973ab8d10055dce7b8f7de1441cc893