[linenoise] fix backspace operation in dumb mode (IDFGH-12475)

[michaelpontillas]

Backspace erases the prompt when dumb mode is enabled.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 17 committers have signed the CLA.

✅ hfudev
❌ kapilkedawat
❌ luomanruo
❌ KonstantinKondrashov
❌ jack0c
❌ ShenWeilong
❌ zwx1995esp
❌ kelin6
❌ MaxwellAlan
❌ gytxxsy
❌ Shreyas0-7
❌ ShyamalKhachane
❌ michaelpontillas
❌ esp-wzh
❌ AdityaHPatwardhan
❌ ChrysalisChenJ
❌ zhaoweiliang2021

---

michaelpontillas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[github-actions]

	Warnings
⚠️	Some issues found for the commit messages in this PR: the commit message "(fix)esp_wifi: wifi beacon timeout after connection established": summary looks empty type/action looks empty the commit message "Fix PB-GATT adv is reported to the app layer too frequently (v5.1)": summary looks empty type/action looks empty the commit message "Merge branch 'bugfix/BLEQABR23-414_v51' into 'release/v5.1'": probably contains Jira ticket reference (BLEQABR23-414). Please remove Jira tickets from commit messages. the commit message "Merge branch 'bugfix/BLEQABR23-632v51' into 'release/v5.1'": probably contains Jira ticket reference (BLEQABR23-632). Please remove Jira tickets from commit messages. the commit message "Merge branch 'feature/update-openocd-to-v0.12.0-esp32-20230921_v5.1' into 'release/v5.1'": probably contains Jira ticket reference (32-20230921). Please remove Jira tickets from commit messages. the commit message "UART: UART_SELECT_WRITE_NOTIF event added in UART driver": type/action should start with a lowercase letter type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test] the commit message "[Usb Serial JTAG] printing to console could sometimes skip bytes": summary looks empty type/action looks empty the commit message "ble: update c2 rom.ld": summary looks too short type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test] the commit message "ble: update c6 h2 lib to 5bd7cb83, c2 lib to 1d31e175": type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test] the commit message "ble: update controller log module for ESP32-C2": type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test] the commit message "ble: update controller log module for ESP32-C6, ESP32-H2 and ESP32-C2": type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test] the commit message "ble: update controller log module for ESP32-H2 and ESP32-C6": type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test] the commit message "ble: update tx power level index of ESP32-H2 and ESP32-C2": type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test] the commit message "ble:update c2 libble to 6a8d1f3d, h2 c6 libble to 57ed7949": summary looks empty type/action looks empty the commit message "bugfix(esp_hw_support): allow reject for lightsleep": type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test] the commit message "change(ble): update c2 lib to 6ed444f2": body must have leading blank line the commit message "doc (nimble): Added the tutorial for ble_multi_adv example.": summary should not end with a period (full stop) summary looks empty type/action looks empty the commit message "doc (nimble): Added the tutorial for coc_blecent example.": summary should not end with a period (full stop) summary looks empty type/action looks empty the commit message "doc(nimble): Added the tutorial for spp_client example. (v5.1)": type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test] the commit message "doc(nimble): Added the tutorial for spp_server example.": summary should not end with a period (full stop) type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test] the commit message "docs: provide CN translation for api-reference/peripherals/adc_oneshot.rst (Backport v5.1)": summary appears to be too long the commit message "docs: provide CN translation for api-reference/peripherals/clk_tree.rst (Backport v5.1)": summary appears to be too long the commit message "docs: provide CN translation for api-reference/peripherals/sdspi_host.rst (Backport v5.1)": summary appears to be too long the commit message "docs: provide CN translation for api-reference/peripherals/spi_slave_hd.rst (Backport v5.1)": summary appears to be too long the commit message "esp_wifi.h typo": summary looks empty type/action looks empty the commit message "feat(bootloader): Update micro-ecc version to v1.1": probably contains Jira ticket reference (CVE-2020). Please remove Jira tickets from commit messages. the commit message "feat(bootloader): adjust dbias of bootloader, change clock of H2 to 64": body must have leading blank line the commit message "feat(bt): Frees BLE memory when no longer in use": body must have leading blank line the commit message "feat(tools): Update OpenOCD version to v0.12.0-esp32-20230921": probably contains Jira ticket reference (32-20230921). Please remove Jira tickets from commit messages. the commit message "fix bug where backspace erases the prompt in dumb mode": summary looks empty type/action looks empty the commit message "fix(CI): fix CI build": summary looks too short scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - . the commit message "fix(ble_mesh): avoid executing bt_mesh_host_init() more than once when using nimble (v5.1)": summary appears to be too long the commit message "fix(ble_mesh): fix compilation failure on using scene model.": summary should not end with a period (full stop) the commit message "fix(bt/bluedroid): Revise the description for index in esp_hf_ag_clcc_response and correct the error return in btc_hf_indchange_notification": summary appears to be too long the commit message "fix(examples): Reverted: Fix example build errors caused by the deep_sleep funcs are returnable": summary appears to be too long the commit message "fix(phy): Fix ble phy_enable/disable api invoking issue for esp32c2,esp32h2 and esp32c6": summary appears to be too long the commit message "fix(pm): fix soc wakeup after wifi disconnected, station no respond after m f null, crash when connected to non_trans bssid": summary appears to be too long the commit message "fix(protocomm): Remove the configuration check of wifi_provisioning for protocomm component": summary appears to be too long the commit message "fix(usb_serial_jtag): Clean-up usb_serial_jtag lose byte fix, Closes https://github.com/espressif/esp-idf/pull/11344": summary appears to be too long the commit message "fix(usb_serial_jtag): Fix usb_serial_jtag wrong return value, vfs lose data randomly,": body must have leading blank line the commit message "fix(wifi): Fix some wifi issue": summary looks too short the commit message "fix(wifi): fix some wifi issues": body must have leading blank line the commit message "fix(wpa_supplicant): Fix few dpp bugs": summary looks too short the commit message "support linenoise maskmode": summary looks empty type/action looks empty the commit message "workaround(phy): workaround c3 BT nimble 2M phy issue": type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test] Please fix these commit messages - here are some basic tips: follow Conventional Commits style correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).
⚠️	Please consider squashing your 250 commits (simplifying branch history).

	Messages
📖	This PR seems to be quite large (total lines of code: 226406), you might consider splitting it into smaller PRs

👋 Hello michaelpontillas, we appreciate your contribution to this project!

---

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

---

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

---

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 21c02fc

[igrr]

Thanks for the fix @michaelpontillas! Looks like you made a PR of a branch derived from release/v5.1 into the master branch. Would you be able to rebase the commit with your fix to master, and make a PR from there? Otherwise there are lots of unrelated commits here.

(If not, we can do the rebase for you, just let us know.)

[michaelpontillas]

Hi Ivan, Thanks for pointing that out. I submitted another pull request. - Michael

…

On Fri, Mar 29, 2024 at 12:13 AM Ivan Grokhotkov ***@***.***> wrote: Thanks for the fix @michaelpontillas <https://github.com/michaelpontillas>! Looks like you made a PR of a branch derived from release/v5.1 into the master branch. Would you be able to rebase the commit with your fix to master, and make a PR from there? Otherwise there are lots of unrelated commits here. — Reply to this email directly, view it on GitHub <#13487 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AY4SR2PMEU6IQYUKM7HM76DY2QCONAVCNFSM6AAAAABFMCK7ROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRVGE2TMMRTGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[michaelpontillas]

Submitted new pull request after rebase to master.