-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fatfs): add Kconfig settings for FF_USE_STRFUNC (IDFGH-12317) #13352
Conversation
👋 Hello KJ7LNW, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Thanks for contribution. |
Hi, thank you for contributing! |
Legacy fatfs code being ported to ESP-IDF may use `f_gets()`, `f_puts()`, `f_putc()`, and `f_printf()` calls, but the define `FF_USE_STRFUNC` is set to 0 without Kconfig options to enable it. This commit retains the existing default behavior of `FF_USE_STRFUNC=0` and adds Kconfig settings so users can configure `FF_USE_STRFUNC` and the related `FF_PRINT_LLI`, `FF_PRINT_FLOAT`, and `FF_STRF_ENCODE` if needed. Closes: espressif#13350 Signed-off-by: Eric Wheeler <[email protected]>
575e2dd
to
1ad0606
Compare
@haberturdeur, updated and force pushed. Please double-check that this is what you needed. |
LGTM! |
Legacy fatfs code being ported to ESP-IDF may use
f_gets()
,f_puts()
,f_putc()
, andf_printf()
calls, but the defineFF_USE_STRFUNC
is set to 0 without Kconfig options to enable it.This commit retains the existing default behavior of
FF_USE_STRFUNC=0
and adds Kconfig settings so users can configureFF_USE_STRFUNC
and the relatedFF_PRINT_LLI
,FF_PRINT_FLOAT
, andFF_STRF_ENCODE
if needed.Closes: #13350
(This PR replaces #13351 which had an invalid branch name due to capital letters.)