Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fatfs): add Kconfig settings for FF_USE_STRFUNC (IDFGH-12317) #13352

Merged
merged 1 commit into from
May 17, 2024

Conversation

KJ7LNW
Copy link
Contributor

@KJ7LNW KJ7LNW commented Mar 11, 2024

Legacy fatfs code being ported to ESP-IDF may use f_gets(), f_puts(), f_putc(), and f_printf() calls, but the define FF_USE_STRFUNC is set to 0 without Kconfig options to enable it.

This commit retains the existing default behavior of FF_USE_STRFUNC=0 and adds Kconfig settings so users can configure FF_USE_STRFUNC and the related FF_PRINT_LLI, FF_PRINT_FLOAT, and FF_STRF_ENCODE if needed.

Closes: #13350

(This PR replaces #13351 which had an invalid branch name due to capital letters.)

Copy link

github-actions bot commented Mar 11, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello KJ7LNW, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 1ad0606

@Alvin1Zhang
Copy link
Collaborator

Thanks for contribution.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Mar 11, 2024
@github-actions github-actions bot changed the title feat(fatfs): add Kconfig settings for FF_USE_STRFUNC feat(fatfs): add Kconfig settings for FF_USE_STRFUNC (IDFGH-12317) Mar 11, 2024
@espressif-bot espressif-bot added Status: Selected for Development Issue is selected for development Status: In Progress Work is in progress and removed Status: Opened Issue is new Status: Selected for Development Issue is selected for development labels Mar 20, 2024
@haberturdeur
Copy link
Collaborator

Hi, thank you for contributing!

components/fatfs/src/ffconf.h Outdated Show resolved Hide resolved
components/fatfs/src/ffconf.h Outdated Show resolved Hide resolved
Legacy fatfs code being ported to ESP-IDF may use `f_gets()`, `f_puts()`,
`f_putc()`, and `f_printf()` calls, but the define `FF_USE_STRFUNC` is set to 0
without Kconfig options to enable it.

This commit retains the existing default behavior of `FF_USE_STRFUNC=0` and
adds Kconfig settings so users can configure `FF_USE_STRFUNC` and the related
`FF_PRINT_LLI`, `FF_PRINT_FLOAT`, and `FF_STRF_ENCODE` if needed.

Closes: espressif#13350
Signed-off-by: Eric Wheeler <[email protected]>
@KJ7LNW KJ7LNW force-pushed the fatfs-ff_use_strfunc branch from 575e2dd to 1ad0606 Compare April 8, 2024 21:37
@KJ7LNW
Copy link
Contributor Author

KJ7LNW commented Apr 8, 2024

@haberturdeur, updated and force pushed. Please double-check that this is what you needed.

@haberturdeur
Copy link
Collaborator

LGTM!

@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed and removed Status: In Progress Work is in progress labels Apr 9, 2024
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Reviewing Issue is being reviewed labels May 16, 2024
@espressif-bot espressif-bot merged commit 1ad0606 into espressif:master May 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fatfs: FF_USE_STRFUNC is not configurable, thus f_gets() is unavailable (IDFGH-12315)
4 participants