Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action to build the code #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cclauss
Copy link

@cclauss cclauss commented Jan 5, 2025

@alex19EP Can you please approve the workflow to see if this build succeeds? Thanks.

@alex19EP
Copy link
Member

hmm. I can't do that. there no workflows to approve.

@cclauss
Copy link
Author

cclauss commented Jan 11, 2025

Test results: https://github.com/cclauss/pcaudiolib/actions

macOS and Windows both fail with ./autogen.sh: line 13: aclocal: command not found

@cclauss
Copy link
Author

cclauss commented Jan 11, 2025

Wow! Ubuntu and macOS in Intel pass but macOS on ARM (Apple Silicon) fails!

Windows fails because I do not know how to install https://www.gnu.org/software/automake

@cclauss
Copy link
Author

cclauss commented Jan 11, 2025

Let's land it like this so that at least the build passes on macOS on Intel and Ubuntu.

Someone with more C++ experience can propose fixes for the macOS on ARM (Apple Silicon) and Windows builds.

@thewh1teagle
Copy link

How about changing to use CMake instead? will be much easier to build it cross platform

@cclauss
Copy link
Author

cclauss commented Jan 23, 2025

@thewh1teagle Let's get the three passing tests merged before we make further changes.

If you are up for creating a pull request for a CMake build, please proceed.

@thewh1teagle
Copy link

thewh1teagle commented Jan 23, 2025

If you are up for creating a pull request for a CMake build, please proceed.

I started working on CMake support in thewh1teagle/pcaudiolib/feat/build-with-cmake. Will be nice if people join me (I enabled issues for discussion)
It will take few days, I'll create new PR when it's ready

By the way, the CI part will be easy once CMake is added as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants