Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license files and top-level README.md, move test binaries to tests/ directory #734

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

jessebraham
Copy link
Member

This is mostly just housekeeping:

  • Updated the copyright date in the license, reformatted Apache 2.0 license (since it was weird before, now matches what we have in esp-hal)
  • Removed noticed from top-level README.md stating that we are not developing any more features (because we are, now)
  • Moved test binaries to the tests/ directory, removed old binaries which are no longer in use
    • I would like to keep resources required by the application and test artifacts separate :)

@@ -1,6 +1,6 @@
# Test Resources

This document describes how the test files under `tests/resources` were generated, so that they can be re-generated in the future if needed.
This document describes how the test files under `tests/data` were generated, so that they can be re-generated in the future if needed.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a note, this document needs updating. However, we no longer have a blinky example in the HAL, so have just left it as-is for now :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a note, this document needs updating

Shall we open an issue about this?

@jessebraham jessebraham added the skip-changelog Skips the changelog CI check label Jan 29, 2025
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@jessebraham jessebraham added this pull request to the merge queue Jan 29, 2025
Merged via the queue into esp-rs:main with commit 3c56608 Jan 29, 2025
28 of 29 checks passed
@jessebraham jessebraham deleted the fixes/misc branch February 3, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips the changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants