Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.3.4 patch #749

Open
wants to merge 4 commits into
base: v1.3.4-release
Choose a base branch
from
Open

V1.3.4 patch #749

wants to merge 4 commits into from

Conversation

downiec
Copy link
Collaborator

@downiec downiec commented Feb 28, 2025

Description

Fixes continuous loop with globus tokens and other small updates.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Local Pre-commit Checks
  • CI/CD Build

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • If applicable - I have commented my code, particularly in hard-to-understand areas
  • If applicable - I have made corresponding changes to the documentation
  • If applicable - I have added tests that prove my fix is effective or that my feature works
  • If applicable - New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

… into a single object, stringify and then save to session storage as a single bundle. This will reduce requests to session storage by consolidating into a single request when values need to be persisted or loaded.
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v1.3.4-release@bbe8565). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                 @@
##             v1.3.4-release      #749   +/-   ##
==================================================
  Coverage                  ?   100.00%           
==================================================
  Files                     ?        34           
  Lines                     ?      1086           
  Branches                  ?         0           
==================================================
  Hits                      ?      1086           
  Misses                    ?         0           
  Partials                  ?         0           
Flag Coverage Δ
backend 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ent to improve globus transfer reliability. Includes extensive refactoring of tests and test components to pass using the new DataBundlePersister class. Updated the cart summary to display info on selected cart items not just on the entire cart totals.
@downiec downiec marked this pull request as ready for review March 5, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant