-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1.1.0 container update #608
Conversation
…er react-scripts has modified during build
Here's a status of all commits made in #594. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.1.0 #608 +/- ##
===========================================
- Coverage 100.00% 98.54% -1.46%
===========================================
Files 30 76 +46
Lines 910 2751 +1841
Branches 0 420 +420
===========================================
+ Hits 910 2711 +1801
- Misses 0 40 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I haven't yet, it's next up. TODO
|
This failed test might be an intermittent issue |
Still trying to figure out why this fails on github but passes locally... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried testing this locally and looks like everything works fine. I think we can merge with v1.1.0 and then I'll figure out why the globus test is failing
Description
This PR will be a general update for containers.
Todo before merge:
Fixes # (issue)
Type of change
How Has This Been Tested?
Checklist